Document std limitations before/after main#115247
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 16, 2023
Merged
Conversation
Collaborator
|
(rustbot has picked a reviewer for you, use r? to override) |
daa7584 to
b96db22
Compare
Amanieu
reviewed
Aug 26, 2023
| //! | ||
| //! Non-exhaustive list of known limitations: | ||
| //! | ||
| //! - after-main use of thread-locals, which also affects additional features: |
Member
There was a problem hiding this comment.
It's not just after main that these can cause issues, they may panic during TLS destruction when any thread is exiting.
Member
Author
There was a problem hiding this comment.
Sure, but this section (and the filed issue it is trying to address) is about before/after main, not about non-main-thread lifecycles.
We could generalize it to "outside std-managed lifecycle scopes" or some similar mouthful?
Member
There was a problem hiding this comment.
I just think this one sentence could be generalized to apply to TLS destruction in general, not just when exiting the main thread.
Member
|
@bors r+ rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 16, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#115247 (Document std limitations before/after main) - rust-lang#115329 (fix std::primitive doc: homogenous -> homogeneous) - rust-lang#115487 (Improve documentation on when signes are printed by default) - rust-lang#115560 (Update doc for `alloc::format!` and `core::concat!`) - rust-lang#115836 (update rust_analyzer_settings.json) - rust-lang#115884 (make ty::Const debug printing less verbose) - rust-lang#115890 (Migrate GUI colors test to original CSS color format) - rust-lang#115895 (Improve Vec(Deque)::truncate documentation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 16, 2023
Rollup merge of rust-lang#115247 - the8472:life-before-main, r=dtolnay Document std limitations before/after main Solves rust-lang#110708
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #110708