Reuse codegen_ssa monomorphization errors in codegen_gcc#113877
Merged
bors merged 2 commits intorust-lang:masterfrom Jul 24, 2023
Merged
Reuse codegen_ssa monomorphization errors in codegen_gcc#113877bors merged 2 commits intorust-lang:masterfrom
codegen_ssa monomorphization errors in codegen_gcc#113877bors merged 2 commits intorust-lang:masterfrom
Conversation
Reduces error duplication and makes it more consistent across backends
Here I am assuming we want to treat these parameters (input, first, second, third, return) as translatable
Collaborator
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
Collaborator
|
Some changes occurred in compiler/rustc_codegen_gcc cc @antoyo |
Contributor
Author
|
@rustbot label +A-translation |
davidtwco
approved these changes
Jul 24, 2023
Member
|
@bors r+ |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (f475098): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 650.993s -> 651.432s (0.07%) |
antoyo
pushed a commit
to antoyo/rust
that referenced
this pull request
Oct 9, 2023
…rphization-errors-in-gcc, r=davidtwco Reuse `codegen_ssa` monomorphization errors in `codegen_gcc` Removes monomorphization errors duplication by reusing the ones defined in `codegen_ssa`. Also updates `expected_simd` errors usage in `codegen_gcc` by assuming we want to treat those parameters as translatable. See rust-lang@7a888fb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes monomorphization errors duplication by reusing the ones defined in
codegen_ssa.Also updates
expected_simderrors usage incodegen_gccby assuming we want to treat those parameters as translatable. See 7a888fb