Skip to content

style-guide: Add section on bugs, and resolving bugs#113383

Merged
bors merged 1 commit intorust-lang:masterfrom
joshtriplett:style-bugs
Sep 19, 2023
Merged

style-guide: Add section on bugs, and resolving bugs#113383
bors merged 1 commit intorust-lang:masterfrom
joshtriplett:style-bugs

Conversation

@joshtriplett
Copy link
Member

@joshtriplett joshtriplett commented Jul 5, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2023

r? @yaahc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-style Relevant to the style team, which will review and decide on the PR/issue. labels Jul 5, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2023

Some changes occurred in src/doc/style-guide

cc @rust-lang/style

@joshtriplett
Copy link
Member Author

joshtriplett commented Jul 5, 2023

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Jul 5, 2023 •
edited
Loading

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

Concerns:

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 5, 2023
calebcartwright
calebcartwright reviewed Jul 14, 2023
View reviewed changes
@calebcartwright
Copy link
Member

calebcartwright commented Aug 10, 2023 •
edited
Loading

@rfcbot concern require_all_checkboxes

@compiler-errors
Copy link
Contributor

compiler-errors commented Aug 11, 2023

@rfcbot resolve require_all_checkboxes

@calebcartwright
Copy link
Member

calebcartwright commented Aug 11, 2023

@rfcbot resolve require all checkboxes

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Aug 11, 2023
@rfcbot
Copy link

rfcbot commented Aug 11, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Aug 21, 2023
@rfcbot
Copy link

rfcbot commented Aug 21, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label Aug 21, 2023
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Aug 24, 2023
@compiler-errors
Copy link
Contributor

compiler-errors commented Sep 18, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 18, 2023

📌 Commit 08a997e has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2023
@bors
Copy link
Collaborator

bors commented Sep 18, 2023

⌛ Testing commit 08a997e with merge 08403d3...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 18, 2023
@bors
Auto merge of rust-lang#113383 - joshtriplett:style-bugs, r=compiler-…
08403d3 
…errors

style-guide: Add section on bugs, and resolving bugs
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Sep 19, 2023

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
 Documenting rustc_ast_passes v0.0.0 (/checkout/compiler/rustc_ast_passes)
[RUSTC-TIMING] rustc_ast_passes test:false 1.709
    Checking rustc_expand v0.0.0 (/checkout/compiler/rustc_expand)
 Documenting rustc_expand v0.0.0 (/checkout/compiler/rustc_expand)
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
##[group]Clock drift check
  local time: Tue Sep 19 00:01:51 UTC 2023
  network time: Tue, 19 Sep 2023 00:01:51 GMT
##[endgroup]
##[endgroup]
Session terminated, killing shell...[RUSTC-TIMING] rustc_expand test:false 2.524
 Documenting rustc_builtin_macros v0.0.0 (/checkout/compiler/rustc_builtin_macros)
 ...killed.
##[error]The operation was canceled.
Cleaning up orphan processes

@bors
Copy link
Collaborator

bors commented Sep 19, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2023
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Sep 19, 2023

@bors rollup=always

@calebcartwright
Copy link
Member

calebcartwright commented Sep 19, 2023

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 19, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2023
@bors
Auto merge of rust-lang#115979 - GuillaumeGomez:rollup-06ujzgh, r=Gui…
ac5ac47 
…llaumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#113383 (style-guide: Add section on bugs, and resolving bugs)
 - rust-lang#115499 (rustc_target/riscv: Fix passing of transparent unions with only one non-ZST member)
 - rust-lang#115801 (Detect cycle errors hidden by opaques during monomorphization)
 - rust-lang#115947 (Custom code classes in docs warning)
 - rust-lang#115957 (fix mismatched symbols)
 - rust-lang#115958 (explain mysterious addition in float minimum/maximum)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7a27acf into rust-lang:master Sep 19, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 19, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2023
@rust-timer
Unrolled build for rust-lang#113383
eebe03f 
Rollup merge of rust-lang#113383 - joshtriplett:style-bugs, r=compiler-errors

style-guide: Add section on bugs, and resolving bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calebcartwright calebcartwright calebcartwright left review comments

Assignees

@yaahc yaahc

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-style Relevant to the style team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.74.0

Development

Successfully merging this pull request may close these issues.

10 participants

@joshtriplett @rustbot @rfcbot @calebcartwright @compiler-errors @bors @rust-log-analyzer @matthiaskrgr @yaahc @apiraino