make custom mir ICE a bit nicer#113039
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 27, 2023
Merged
Conversation
Collaborator
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
| } | ||
| other => { | ||
| panic!("Unexpected key {}", other); | ||
| bug!("Unexpected key while parsing custom_mir attribute: '{}'", other); |
Contributor
There was a problem hiding this comment.
Suggested change
| bug!("Unexpected key while parsing custom_mir attribute: '{}'", other); | |
| span_bug!(nested.span, "Unexpected key while parsing custom_mir attribute: '{}'", other); |
I think this works?
compiler-errors
approved these changes
Jun 25, 2023
Contributor
compiler-errors
left a comment
There was a problem hiding this comment.
r=me preferably with change. i think there's some span you can use here.
Member
Author
|
@bors rollup=always r=compiler-errors |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 27, 2023
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#113039 (make custom mir ICE a bit nicer) - rust-lang#113058 (Add/improve code comments) - rust-lang#113063 (Update books) r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
Member
Author
|
o.O |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.