Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @scottmcm (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

I'm going to flip this to libs-api, on the assumption that this implies more stuff from Pattern on stable.

r? rust-lang/libs-api

This may be made more relevant by #100806

@rust-lang/libs-api:
@rfcbot fcp merge

This PR makes iterators from split_inclusive([char; N]) and split_inclusive(&[char; N]) usable as a DoubleEndedIterator. The searcher when a slice is used as the pattern, split_inclusive(&[char]), already has the impl for this. All 3 of these iterators perform the same behavior so it makes no sense to have DoubleEndedIterator for some but not all.

fn main() {
    let mut iter = "x86_64-unknown-none".split_inclusive(['-', '_']);
    let _ = iter.next_back();
}

Be aware that the above code already compiles without this PR, but that is a bug. #100806

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

• @Amanieu
• @BurntSushi
• @dtolnay
• @joshtriplett
• @m-ou-se

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

🔔 This is now entering its final comment period, as per the review above. 🔔

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@bors r+

📌 Commit c6ed532 has been approved by dtolnay

It is now in the queue for this repository.

⌛ Testing commit c6ed532 with merge f6dcaee...

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing f6dcaee to master...

Finished benchmarking commit (f6dcaee): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Cycles

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.246s -> 675.186s (0.14%)
Artifact size: 313.61 MiB -> 313.59 MiB (-0.01%)

Nominating for backport into 1.75.0 to put this into the same release as #100806. It would be needlessly annoying to break "...".split_inclusive([...]).rev() in one release and unbreak it in the next release, when we can just not break it.