Skip to content

(docs) Change "wanting" to "want"#111582

Merged
bors merged 1 commit intorust-lang:masterfrom
Vagelis-Prokopiou:fix/wanting
May 15, 2023
Merged

(docs) Change "wanting" to "want"#111582
bors merged 1 commit intorust-lang:masterfrom
Vagelis-Prokopiou:fix/wanting

Conversation

@Vagelis-Prokopiou
Copy link
Contributor

@Vagelis-Prokopiou Vagelis-Prokopiou commented May 15, 2023

Changing " If you’re wanting" to "If you want".

Wanting is not wrong, of course, but I think that "If you want" feels more natural to most readers.

@rustbot
Copy link
Collaborator

rustbot commented May 15, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 15, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 15, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@workingjubilee
Copy link
Member

workingjubilee commented May 15, 2023

I agree.
@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented May 15, 2023

📌 Commit 5fa8c4a has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request May 15, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2023
@bors
Auto merge of rust-lang#111585 - matthiaskrgr:rollup-468pykj, r=matth…
2913ad6 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#102673 (Update doc for `PhantomData` to match code example)
 - rust-lang#111531 (Fix ice caused by shorthand fields in NoFieldsForFnCall)
 - rust-lang#111547 (Start node has no immediate dominator)
 - rust-lang#111548 (add util function to TokenStream to eliminate some clones)
 - rust-lang#111560 (Simplify find_width_of_character_at_span.)
 - rust-lang#111569 (Appease lints)
 - rust-lang#111581 (Fix some misleading and copy-pasted `Pattern` examples)
 - rust-lang#111582 ((docs) Change "wanting" to "want")

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 75186c0 into rust-lang:master May 15, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 15, 2023
@Vagelis-Prokopiou Vagelis-Prokopiou deleted the fix/wanting branch March 27, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thomcc thomcc

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.71.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Vagelis-Prokopiou @rustbot @workingjubilee @bors @thomcc