Merged
Conversation
Member
There was a problem hiding this comment.
Weird that the test doesn't contain any autoref anymore, even though it should test for it... The move seems fine though
Contributor
Author
There was a problem hiding this comment.
Issue is from 2012 and doesn't seem relevant anymore.
Contributor
Author
|
Thanks for the review @WaffleLapkin |
Member
|
@c410-f3r what's the status here? will you address (the first two) of my comments? |
Contributor
Author
Hahahaha, they were addressed since my last comment but I didn't push any changes 😵💫 |
Member
|
@bors r+ rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 29, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#111558 (Move tests) - rust-lang#111827 (Add build instructions for cranelift backend as part of Rust repo) - rust-lang#111988 (Make `TyKind: Debug` have less verbose output) - rust-lang#112022 (Check nested obligations during coercion unify in new solver) - rust-lang#112057 (Suggest correct `self_ty`) - rust-lang#112063 (Add a test for issue 110457/incremental ICE with closures with the same span) Failed merges: - rust-lang#112068 (Move tests from `ui/discrim` dir) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @petrochenkov