Skip to content

Don't use can_eq in derive(..) suggestion for missing method#111516

Merged
bors merged 1 commit intorust-lang:masterfrom
compiler-errors:issue-111500
Jun 3, 2023
Merged

Don't use can_eq in derive(..) suggestion for missing method#111516
bors merged 1 commit intorust-lang:masterfrom
compiler-errors:issue-111500

Conversation

@compiler-errors
Copy link
Contributor

@compiler-errors compiler-errors commented May 12, 2023 •
edited
Loading

Unsatisfied predicates returned from method probe may reference inference vars from that probe, so drop this extra check I added in #110877 for more accurate derive suggestions...

Fixes #111500

@rustbot
Copy link
Collaborator

rustbot commented May 12, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 12, 2023
@apiraino
Copy link
Contributor

apiraino commented Jun 1, 2023

r? compiler

@rustbot rustbot assigned jackh726 and unassigned davidtwco Jun 1, 2023
@jackh726
Copy link
Member

jackh726 commented Jun 3, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 3, 2023

📌 Commit c5604cd has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2023
@bors
Copy link
Collaborator

bors commented Jun 3, 2023

⌛ Testing commit c5604cd with merge 8177591...

@bors
Copy link
Collaborator

bors commented Jun 3, 2023

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 8177591 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 3, 2023
@bors bors merged commit 8177591 into rust-lang:master Jun 3, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 3, 2023
@rust-timer
Copy link
Collaborator

rust-timer commented Jun 3, 2023

Finished benchmarking commit (8177591): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.2% [2.2%, 2.2%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.3% [1.3%, 4.3%] 7
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.3% [1.3%, 4.3%] 7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 647.604s -> 647.289s (-0.05%)

@lqd lqd mentioned this pull request Jul 25, 2023
Closed
@lqd
Copy link
Member

lqd commented Jul 25, 2023 •
edited
Loading

PR #110877 has landed on stable a couple weeks ago, so the diagnostics ICE #111500 and similar happen there now, while beta and nightly are fine thanks to this PR.

So if there's ever a 1.71 point release, it could be interesting to backport this PR to stable :

These couple duplicate issues likely wouldn't warrant such a point release by themselves, and the ICE should be rare enough in practice, but we'll see if more people encounter this in the future.

Nominating for discussion for stable backport.

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated Nominated for backporting to the compiler in the stable channel. label Jul 25, 2023
@lqd lqd mentioned this pull request Jul 25, 2023
Open
@cuviper
Copy link
Member

cuviper commented Jul 25, 2023

So if there's ever a 1.71 point release,

We are planning 1.71.1 for August 3rd:
https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/1.2E71.2E1

@apiraino
Copy link
Contributor

apiraino commented Jul 28, 2023

Stable backport approved as per compiler team on Zulip

@rustbot label +stable-accepted

@rustbot rustbot added the stable-accepted Accepted for backporting to the compiler in the stable channel. label Jul 28, 2023
@emilyalbini emilyalbini mentioned this pull request Jul 31, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 31, 2023
@bors
Auto merge of rust-lang#114284 - pietroalbini:pa-1.72.1, r=pietroalbini
7c79013 
Prepare Rust 1.71.1

This PR prepares the Rust 1.71.1 release, which contains:

* rust-lang#113802
* rust-lang#113579
* rust-lang#111516
* rust-lang#112517
* rust-lang@67b5990 (from rust-lang#113678)

r? `@ghost`
cc `@rust-lang/release`
@compiler-errors compiler-errors deleted the issue-111500 branch August 11, 2023 20:05
@cuviper cuviper removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Aug 12, 2023
@cuviper cuviper modified the milestones: 1.72.0, 1.71.1 Aug 12, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jackh726 jackh726

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. stable-accepted Accepted for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.71.1

Development

Successfully merging this pull request may close these issues.

ICE: index out of bounds: the len is 2 but the index is 6' snapshot_vec

9 participants

@compiler-errors @rustbot @apiraino @jackh726 @bors @rust-timer @lqd @cuviper @davidtwco