Substitute missing trait items suggestion correctly#110555
Merged
bors merged 3 commits intorust-lang:masterfrom Apr 21, 2023
Merged
Substitute missing trait items suggestion correctly#110555bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
97fec71 to
f362f6e
Compare
Contributor
|
@bors r+ rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 21, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#110365 (ship tools with sysroot) - rust-lang#110555 (Substitute missing trait items suggestion correctly) - rust-lang#110578 (fix(error): normalize whitespace during msg_to_buffer) - rust-lang#110597 (remove unused ftl messages) - rust-lang#110611 (Add regression test for rust-lang#46506) - rust-lang#110618 (Track if EvalCtxt has been tainted, make sure it can't be used to make query responses after) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly substitute missing item suggestions, so that when they reference generics from their parent trait they actually have the right time for the impl.
Also, some other minor tweaks like using
/* Type */to signify a GAT's type is actually missing, and fixing generic arg suggestions for GATs in general.