Migrate most of rustc_builtin_macros to diagnostic impls#110092
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 11, 2023
Merged
Migrate most of rustc_builtin_macros to diagnostic impls#110092bors merged 1 commit intorust-lang:masterfrom
rustc_builtin_macros to diagnostic impls#110092bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
fbstj
reviewed
Apr 8, 2023
e4c55da to
64d2234
Compare
48260ef to
37b1f96
Compare
Co-authored-by: Joe ST <joe@fbstj.net> Co-authored-by: Michael Goulet <michael@errs.io>
37b1f96 to
64f7597
Compare
Collaborator
|
|
Contributor
|
ty @bors delegate+ r=me when green |
Collaborator
|
✌️ @clubby789 can now approve this pull request |
Contributor
Author
|
@bors r=compiler-errors |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (45749b2): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 8, 2023
…henkov Remove accidental comment Left this in in rust-lang#110092 while debugging, thanks to `@WaffleLapkin` for spotting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #100717
This is a couple of days work, but I decided to stop for now before the PR becomes too big. There's around 50 unresolved failures when
rustc::untranslatable_diagnosticis denied, which I'll finish addressing once this PR goes thtoughA couple of outputs have changed, but in all instances I think the changes are an improvement/are more consistent with other diagnostics (although I'm happy to revert any which seem worse)