Updating Wake example to use new 'pin!' macro#110026
Closed
madsravn wants to merge 3 commits intorust-lang:masterfrom
madsravn:master
Closed
Updating Wake example to use new 'pin!' macro#110026madsravn wants to merge 3 commits intorust-lang:masterfrom madsravn:master
madsravn wants to merge 3 commits intorust-lang:masterfrom
madsravn:master
Conversation
Collaborator
|
(rustbot has picked a reviewer for you, use r? to override) |
Collaborator
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Member
|
@bors r+ rollup |
Collaborator
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 9, 2023
Updating Wake example to use new 'pin!' macro Updating the example for the Wake trait to use `pin!` macro instead of `Box::pin`. rust-lang#109965
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 25, 2023
…lacrum Updating Wake example to use new 'pin!' macro Closes: rust-lang#109965 I have already had this reviewed and approved here: rust-lang#110026 . But because I had some git issues and chose the "nuke it" option as my solution it didn't get merged. I nuked it too quickly. I am sorry for trouble of reviewing twice.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 25, 2023
…lacrum Updating Wake example to use new 'pin!' macro Closes: rust-lang#109965 I have already had this reviewed and approved here: rust-lang#110026 . But because I had some git issues and chose the "nuke it" option as my solution it didn't get merged. I nuked it too quickly. I am sorry for trouble of reviewing twice.
thomcc
pushed a commit
to pgcentralfoundation/postgrestd
that referenced
this pull request
Jul 18, 2023
Updating Wake example to use new 'pin!' macro Closes: rust-lang/rust#109965 I have already had this reviewed and approved here: rust-lang/rust#110026 . But because I had some git issues and chose the "nuke it" option as my solution it didn't get merged. I nuked it too quickly. I am sorry for trouble of reviewing twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the example for the Wake trait to use
pin!macro instead ofBox::pin.#109965