Pull some tuple variant fields out into their own struct#109723
Pull some tuple variant fields out into their own struct#109723bors merged 5 commits intorust-lang:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Nilstrieb (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
Noratrieb
left a comment
There was a problem hiding this comment.
r=me when the static docs are back in and with or without the ast_pretty change
There was a problem hiding this comment.
print_item_const could now take an ast::ConstItem as an argument
There was a problem hiding this comment.
Unfortunately this doesn't work yet. We'll need to merge the shared parts of const items and static items first.
|
@bors r=Nilstrieb |
…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#109723 (Pull some tuple variant fields out into their own struct) - rust-lang#109838 (Fix `non_exhaustive_omitted_patterns` lint span) - rust-lang#109901 (Enforce VarDebugInfo::Place in MIR validation.) - rust-lang#109913 (Doc-comment `IndexVec::from_elem` and use it in a few more places) - rust-lang#109914 (Emit feature error for parenthesized generics in associated type bounds) - rust-lang#109919 (rustdoc: escape GAT args in more cases) - rust-lang#109937 (Don't collect return-position impl traits for documentation) - rust-lang#109938 (Move a const-prop-lint specific hack from mir interpret to const-prop-lint and make it fallible) - rust-lang#109940 (Add regression test for rust-lang#93911) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This is groundwork for adding more fields to those new structs, but I believe the change to be useful on its own.
r? @Nilstrieb but feel free to reroll for
compiler