r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

I think you can use maybe_get_struct_pattern_shorthand_field here instead of matching on the hir yourself?

Or better yet -- i wonder if we could make an even better helper method that simplifies the duplicated logic between all of the suggestions that handle field init shorthand syntax specially...

Or better yet -- i wonder if we could make an even better helper method that simplifies the duplicated logic between all of the suggestions that handle field init shorthand syntax specially...

try to move the span part to maybe_get_struct_pattern_shorthand_field, seems better now?

Hmm... I don't really like the new calls to span_to_snippet... I wonder if we could just return a Vec<(Span, String)> that's either "field: " or empty that we can then use for the multipart suggestion...

r? @compiler-errors

Hmm... I don't really like the new calls to span_to_snippet... I wonder if we could just return a Vec<(Span, String)> that's either "field: " or empty that we can then use for the multipart suggestion...

I have a try, but seems maybe_get_struct_pattern_shorthand_field is not only used for fields and multipart suggestion, so we need to return an Option<> which also will make the code somehow not easy to read.

I rollback my last commit, and use the original maybe_get_struct_pattern_shorthand_field now.

@bors r+

📌 Commit 64f6e4f has been approved by compiler-errors

It is now in the queue for this repository.

@bors rollup