Skip to content

Fix docs for alloc::realloc#108630

Merged
bors merged 1 commit intorust-lang:masterfrom
overlookmotel:realloc-docs-fix
May 27, 2023
Merged

Fix docs for alloc::realloc#108630
bors merged 1 commit intorust-lang:masterfrom
overlookmotel:realloc-docs-fix

Conversation

@overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Mar 1, 2023

Fixes #108546.

Corrects the docs for alloc::realloc to bring the safety constraints into line with Layout::from_size_align_unchecked's constraints.

@rustbot
Copy link
Collaborator

rustbot commented Mar 1, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) soon.

Please see the contribution
instructions for more information. Namely, in order to ensure the
minimum review times lag, PR authors and assigned reviewers should ensure that the review
label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:
@rustbot author: the review is finished, PR author should check the comments and take action accordingly @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 1, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 1, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@cuviper
Copy link
Member

cuviper commented Mar 2, 2023

See #108546 (comment), this was deliberately left out of the isize::MAX limits for now...

@cuviper cuviper added S-waiting-on-team and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2023
@cuviper
Copy link
Member

cuviper commented Mar 15, 2023

Closing to defer the decision to rust-lang/libs-team#61

@cuviper cuviper closed this Mar 15, 2023
@Amanieu Amanieu reopened this May 17, 2023
@m-ou-se m-ou-se added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 17, 2023
@Amanieu Amanieu added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 17, 2023
@Amanieu
Copy link
Member

Amanieu commented May 17, 2023

We discussed this in the libs meeting and decided that this is the best way forward for GlobalAlloc. Adding a new method would cause too much churn and we plan on deprecating GlobalAlloc to replace it with Allocator everywhere.

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented May 17, 2023 •
edited by BurntSushi
Loading

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels May 17, 2023
@Amanieu Amanieu mentioned this pull request May 17, 2023
Closed
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels May 17, 2023
@rfcbot
Copy link

rfcbot commented May 17, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels May 27, 2023
@rfcbot
Copy link

rfcbot commented May 27, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label May 27, 2023
@Amanieu
Copy link
Member

Amanieu commented May 27, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 27, 2023

📌 Commit 48e8126 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team labels May 27, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request May 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 27, 2023
@bors
Auto merge of rust-lang#112025 - matthiaskrgr:rollup-j693v67, r=matth…
cca7ee5 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#108630 (Fix docs for `alloc::realloc`)
 - rust-lang#109084 (rustc driver: Remove argument 0 before at-expansion to prevent ICE)
 - rust-lang#111181 (fix(parse): return unpected when current token is EOF)
 - rust-lang#111656 (Use an unbounded lifetime in `String::leak`.)
 - rust-lang#111946 (rustdoc: Add `ItemTemplate` trait and related functions to avoid repetitively wrapping existing functions)
 - rust-lang#112018 (Clean up usage of `cx.tcx` when `tcx` is already set into a variable)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1d06bb9 into rust-lang:master May 27, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 27, 2023
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jun 15, 2023
@overlookmotel overlookmotel deleted the realloc-docs-fix branch July 24, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuviper cuviper

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.71.0

Development

Successfully merging this pull request may close these issues.

alloc::realloc does not follow requirements of Layout::from_size_align_unchecked

8 participants

@overlookmotel @rustbot @cuviper @Amanieu @rfcbot @bors @m-ou-se @apiraino