Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

I wonder if it makes sense to distinguish here between "used in docs" vs "not used in docs", say via a doc_ prefix, but looking at the code, it seems that basically every parameter is only used in docs except for ActualT...

it seems that basically every parameter is only used in docs

Hmm, I suppose there's something fundamental here: the only reason that these have to be macro parameters at all is to use them lexically in docs.

Whenever they're used by actual code, they could have just been private associated types/constants instead. (For example, it could use Self::UnsignedType/Self::SignedType instead of $UnsignedT/$SignedT, and just define those in the impl block, rather than passing them as parameters.)

But regardless, this PR is still good-to-go on its own as a nice improvement

@bors r+ rollup

(It's making me think that maybe BITS_MINUS_ONE being an expr isn't useful, for example -- if it's not a literal then it could just use ($BITS-1) if it needed it. Similarly for BITS, which is always sizeof(Self)*8 if it being an expr is fine. But none of those things are this PR's problem.)

📌 Commit eb5d82b has been approved by scottmcm

It is now in the queue for this repository.