Reduce interning by nnethercote · Pull Request #107869 · rust-lang/rust

nnethercote · 2023-02-10T04:35:49Z

r? @compiler-errors

nnethercote · 2023-02-10T04:36:04Z

@bors try @rust-timer queue

bors · 2023-02-10T04:36:13Z

⌛ Trying commit 887a7fa13cb419f29bd31baf1a8edd5634c9c0af with merge 0ec14f32e473219e6d78a4fe07fd46aeead0e21e...

compiler-errors

one nit about mk_array_const's name, r=me if/when perf comes back green.

compiler/rustc_middle/src/ty/context.rs

compiler/rustc_const_eval/src/transform/check_consts/qualifs.rs

compiler/rustc_middle/src/ty/context.rs

bors · 2023-02-10T07:28:58Z

☀️ Try build successful - checks-actions
Build commit: 0ec14f32e473219e6d78a4fe07fd46aeead0e21e (0ec14f32e473219e6d78a4fe07fd46aeead0e21e)

rust-timer · 2023-02-10T09:09:48Z

Finished benchmarking commit (0ec14f32e473219e6d78a4fe07fd46aeead0e21e): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.7%, -0.3%]	9
Improvements ✅ (secondary)	-1.3%	[-2.6%, -0.3%]	17
All ❌✅ (primary)	-0.4%	[-0.7%, -0.3%]	9

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	2.8%	[1.9%, 4.0%]	17
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.7%	[-1.8%, -1.5%]	4
All ❌✅ (primary)	3.1%	[3.1%, 3.1%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-3.2%	[-4.5%, -1.0%]	6
All ❌✅ (primary)	-1.4%	[-1.4%, -1.4%]	1

compiler/rustc_hir_typeck/src/pat.rs

compiler/rustc_middle/src/ty/context.rs

This requires some rearrangement of plumbing, such as adding `mk_fresh_{,int_,float_}ty` and removing `mk_ty_infer`.

We use more specific `mk_*` functions in most places, might as well use them as much as possible.

nnethercote · 2023-02-12T22:51:41Z

I addressed the review comments.

@bors r=compiler-errors

bors · 2023-02-12T22:51:43Z

📌 Commit e261665 has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2023-02-13T00:35:28Z

⌛ Testing commit e261665 with merge 7740f9a...

bors · 2023-02-13T04:05:56Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 7740f9a to master...

rust-timer · 2023-02-13T05:24:29Z

Finished benchmarking commit (7740f9a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-2.6%, -0.4%]	12
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	3.6%	[3.6%, 3.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-5.0%, -1.8%]	4
All ❌✅ (primary)	3.1%	[3.1%, 3.1%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.3%, -0.9%]	2
Improvements ✅ (secondary)	-3.1%	[-3.9%, -2.1%]	8
All ❌✅ (primary)	-1.1%	[-1.3%, -0.9%]	2

…r-errors Optimize `mk_region` PR rust-lang#107869 avoiding some interning under `mk_ty` by special-casing `Ty` variants with simple (integer) bodies. This PR does something similar for regions. r? `@compiler-errors`

rustbot assigned compiler-errors Feb 10, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 10, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 10, 2023

compiler-errors approved these changes Feb 10, 2023

View reviewed changes

compiler/rustc_middle/src/ty/context.rs Outdated Show resolved Hide resolved

compiler/rustc_const_eval/src/transform/check_consts/qualifs.rs Outdated Show resolved Hide resolved

compiler/rustc_middle/src/ty/context.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 10, 2023

jackh726 reviewed Feb 10, 2023

View reviewed changes

compiler/rustc_hir_typeck/src/pat.rs Outdated Show resolved Hide resolved

compiler/rustc_middle/src/ty/context.rs Outdated Show resolved Hide resolved

compiler/rustc_middle/src/ty/context.rs Outdated Show resolved Hide resolved

nnethercote added 3 commits February 13, 2023 09:25

Pre-intern some commonly used type variables.

6248bbb

This requires some rearrangement of plumbing, such as adding `mk_fresh_{,int_,float_}ty` and removing `mk_ty_infer`.

Reduce direct mk_ty usage.

7a72560

We use more specific `mk_*` functions in most places, might as well use them as much as possible.

Avoid interning empty tuples.

e261665

nnethercote force-pushed the reduce-interning branch from 887a7fa to e261665 Compare February 12, 2023 22:51

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2023

bors mentioned this pull request Feb 13, 2023

Fix unintentional UB in SIMD tests #107973

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 13, 2023

bors merged commit 7740f9a into rust-lang:master Feb 13, 2023

rustbot added this to the 1.69.0 milestone Feb 13, 2023

bors mentioned this pull request Feb 13, 2023

Move folding & visiting traits into type library #107924

Merged

bors mentioned this pull request Feb 13, 2023

Make str into a libcore struct (redux) #107939

Closed

3 tasks

nnethercote deleted the reduce-interning branch February 13, 2023 22:59

nnethercote mentioned this pull request Feb 14, 2023

Optimize mk_region #108020

Merged

compiler-errors mentioned this pull request May 24, 2025

Pre-intern some const infer vars #141499

Closed

Uh oh!

Conversation

nnethercote commented Feb 10, 2023

Uh oh!

nnethercote commented Feb 10, 2023

Uh oh!

This comment has been minimized.

bors commented Feb 10, 2023

Uh oh!

compiler-errors left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bors commented Feb 10, 2023

Uh oh!

This comment has been minimized.

rust-timer commented Feb 10, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nnethercote commented Feb 12, 2023

Uh oh!

bors commented Feb 12, 2023

Uh oh!

bors commented Feb 13, 2023

Uh oh!

bors commented Feb 13, 2023

Uh oh!

rust-timer commented Feb 13, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants