Set rust-analyzer.check.invocationLocation to root#107819
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 9, 2023
Merged
Set rust-analyzer.check.invocationLocation to root#107819bors merged 1 commit intorust-lang:masterfrom
rust-analyzer.check.invocationLocation to root#107819bors merged 1 commit intorust-lang:masterfrom
Conversation
jyn514
reviewed
Feb 8, 2023
Member
jyn514
left a comment
There was a problem hiding this comment.
Did rust-analyzer.cargo.buildScripts.invocationLocation get renamed or something?
Contributor
Author
|
cargo.buildScripts has seperate but similar options to check |
Member
|
@bors r+ rollup Thanks for catching this! |
Collaborator
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Feb 9, 2023
Set `rust-analyzer.check.invocationLocation` to `root`
Add
```json
"rust-analyzer.check.invocationLocation": "root",
"rust-analyzer.check.invocationStrategy": "once",
```
to the bundled VS code config. This prevents an error with r-a invoking `python3 x.py` in `src/bootstrap` where `x.py` does not exist.
r? `@jyn514`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 9, 2023
…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#107317 (Implement `AsFd` and `AsRawFd` for `Rc`) - rust-lang#107429 (Stabilize feature `cstr_from_bytes_until_nul`) - rust-lang#107713 (Extend `BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE`.) - rust-lang#107761 (Replace a command line flag with an env var to allow tools to initialize the tracing loggers at their own discretion) - rust-lang#107790 ( x.py fails all downloads that use a tempdir with snap curl rust-lang#107722) - rust-lang#107799 (correctly update goals in the cache) - rust-lang#107813 (Do not eagerly recover for bad `impl Trait` types in macros) - rust-lang#107817 (rustdoc: use svgo to shrink `wheel.svg`) - rust-lang#107819 (Set `rust-analyzer.check.invocationLocation` to `root`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
to the bundled VS code config. This prevents an error with r-a invoking
python3 x.pyinsrc/bootstrapwherex.pydoes not exist.r? @jyn514