Allow automatically creating vscode settings.json with x setup#107757
Allow automatically creating vscode settings.json with x setup#107757bors merged 1 commit intorust-lang:masterfrom
settings.json with x setup#107757Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
78708b0 to
23829a6
Compare
jyn514
left a comment
There was a problem hiding this comment.
This looks reasonable to me :) I would like to change https://rustc-dev-guide.rust-lang.org/building/suggested.html#configuring-rust-analyzer-for-rustc to point here instead of telling people to copy-paste the config - do you mind making a PR with that change? Ideally it would also point people to src/etc/vscode_settings.json.
I mentioned versioning the config in the original issue - is that something you're interested in working on? It's ok if the answer is no :) I think we can add it in a backwards-compatible way if we go by the hash of the settings.json file instead of using stamp files.
|
What would be best for the versioning? Maybe this:
And I'm happy to make a PR to the dev guide once this one is ready. |
23829a6 to
54861c9
Compare
I think we need a hash of all historical versions if we want to be able to update old versions without prompting. Otherwise we can't tell apart user-defined configs from old versions of managed configs. That said we don't need a list of hashes right away because for now we can just hash Everything else you said sounds great :) |
54861c9 to
e9ff209
Compare
|
I decided to add a list of a single hash initially so we can make sure |
settings.json from bootstrapsettings.json with x setup
e9ff209 to
b695ed9
Compare
jyn514
left a comment
There was a problem hiding this comment.
this is great, thanks! r=me with the last nit fixed :)
b695ed9 to
eb18293
Compare
|
@bors r+ thank you!!! |
|
:ferrisHmm: related |
…yn514 Allow automatically creating vscode `settings.json` with `x setup` Closes rust-lang#107703
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107656 (Bump rust-installer) - rust-lang#107757 (Allow automatically creating vscode `settings.json` with `x setup`) - rust-lang#107769 (Rename `PointerSized` to `PointerLike`) - rust-lang#107770 (rustdoc: use a newline instead of `<br>` to format code headers) - rust-lang#107771 (Tweak ICE message) - rust-lang#107773 (Clearly signal purpose of the yaml template) - rust-lang#107776 (Docs: Fix format of headings in String::reserve) - rust-lang#107779 (Remove astconv usage in diagnostic) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Is there a check somewhere that verifies that the hash is correctly updated? |
|
@albertlarsan68 src/bootstrap/setup/tests.rs tests the last hash matches the current bundled file. |
Closes #107703