Conversation
The handling of async constructs in the compiler does not rely on `GenFuture` anymore since `1.67`, so this code can now be removed from `core`.
|
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
| task::Poll, | ||
| }; | ||
|
|
||
| #[rustc_diagnostic_item = "gen_future"] |
There was a problem hiding this comment.
Is there any code that uses this diagnosics item?
There was a problem hiding this comment.
I don’t think so, grepping through the whole codebase only yields leftover uses of the feature gate.
| /// better error messages (`impl Future` rather than `GenFuture<[closure.....]>`). | ||
| // This is `const` to avoid extra errors after we recover from `const async fn` | ||
| #[doc(hidden)] | ||
| #[unstable(feature = "gen_future", issue = "50547")] |
There was a problem hiding this comment.
Is there some code that uses this feature gate? Possibly in ast lowering? Probably should remove that too.
There was a problem hiding this comment.
The feature gate is still being used for the other implementation details of async lowering in this file.
|
LGTM! @bors r+ rollup |
Rollup of 8 pull requests Successful merges: - rust-lang#107245 (Implement unsizing in the new trait solver) - rust-lang#107445 (Remove `GenFuture` from core) - rust-lang#107473 (Update books) - rust-lang#107476 (rustdoc: remove unnecessary wrapper `div.item-decl` from HTML) - rust-lang#107477 (Migrate last part of CSS themes to CSS variables) - rust-lang#107479 (Use `ObligationCtxt::new_in_snapshot` in `satisfied_from_param_env`) - rust-lang#107482 (rustdoc: remove meta keywords from HTML) - rust-lang#107494 (fix link in std::path::Path::display()) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
The handling of async constructs in the compiler does not rely on
GenFutureanymore since1.67, so this code can now be removed fromcore.