Skip to content

Add note about absolute paths to Path::join#107114

Merged
bors merged 2 commits intorust-lang:masterfrom
Erk-:add-absolute-note-to-path-join
Jan 22, 2023
Merged

Add note about absolute paths to Path::join#107114
bors merged 2 commits intorust-lang:masterfrom
Erk-:add-absolute-note-to-path-join

Conversation

@Erk-
Copy link
Contributor

@Erk- Erk- commented Jan 20, 2023

The note already exists on PathBuf::push, but I think it is good to have it on Path::join as well since it can cause issues if you are not careful with your input.

@rustbot
Copy link
Collaborator

rustbot commented Jan 20, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 20, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 20, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@albertlarsan68
Copy link
Member

albertlarsan68 commented Jan 20, 2023

@rustbot label +A-docs

@rustbot rustbot added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Jan 20, 2023
@m-ou-se m-ou-se assigned m-ou-se and unassigned cuviper Jan 20, 2023
@m-ou-se
Copy link
Member

m-ou-se commented Jan 20, 2023

Can you also add an example in the example snippet?

Something like

assert_eq!(Path::new("/etc").join("/bin/sh"), PathBuf::from("/bin/sh"));

@rustbot

This comment was marked as off-topic.

Sign in to view
@m-ou-se
Copy link
Member

m-ou-se commented Jan 20, 2023

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 20, 2023

📌 Commit d8f8adf has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 20, 2023
@matthiaskrgr
Rollup merge of rust-lang#107114 - Erk-:add-absolute-note-to-path-joi…
52b2ea6 
…n, r=m-ou-se

Add note about absolute paths to Path::join

The note already exists on `PathBuf::push`, but I think it is good to have it on `Path::join` as well since it can cause issues if you are not careful with your input.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 20, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 21, 2023
@matthiaskrgr
Rollup merge of rust-lang#107114 - Erk-:add-absolute-note-to-path-joi…
9f0f792 
…n, r=m-ou-se

Add note about absolute paths to Path::join

The note already exists on `PathBuf::push`, but I think it is good to have it on `Path::join` as well since it can cause issues if you are not careful with your input.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 21, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 22, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2023
@bors
Auto merge of rust-lang#107187 - matthiaskrgr:rollup-lvwzlg2, r=matth…
cef633d 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#107102 (Implement some more predicates in the new solver)
 - rust-lang#107111 (Fix missing arguments issues and copy-paste bug for fluent)
 - rust-lang#107114 (Add note about absolute paths to Path::join)
 - rust-lang#107127 (Enable sanitizers for s390x-linux)
 - rust-lang#107152 (Migrate scraped-examples top and bottom "borders" to CSS variables)
 - rust-lang#107170 (Add myself to .mailmap)
 - rust-lang#107174 (rustdoc: Use `DefId(Map,Set)` instead of `FxHash(Map,Set)`)
 - rust-lang#107180 (Remove unnecessary `&format!`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 17b9f2a into rust-lang:master Jan 22, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 22, 2023
@Erk- Erk- deleted the add-absolute-note-to-path-join branch January 23, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@m-ou-se m-ou-se

Labels

A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Erk- @rustbot @albertlarsan68 @m-ou-se @bors @cuviper