Don't wf-check non-local RPITs#107038
Merged
bors merged 3 commits intorust-lang:masterfrom Jan 19, 2023
Merged
Conversation
oli-obk
reviewed
Jan 19, 2023
oli-obk
reviewed
Jan 19, 2023
aa17359 to
9793abc
Compare
Contributor
Author
oli-obk
reviewed
Jan 19, 2023
| proc_macro: Table<DefIndex, MacroKind>, | ||
| module_reexports: Table<DefIndex, LazyArray<ModChild>>, | ||
| deduced_param_attrs: Table<DefIndex, LazyArray<DeducedParamAttrs>>, | ||
| is_type_alias_impl_trait: Table<DefIndex, LazyValue<bool>>, |
Contributor
There was a problem hiding this comment.
Suggested change
| is_type_alias_impl_trait: Table<DefIndex, LazyValue<bool>>, | |
| is_type_alias_impl_trait: Table<DefIndex, ()>, |
we usually don't encode false, and just use the lack of an entry for that
Contributor
|
@bors r+ p=5 let's land this now and figure out the encoding nit later |
Collaborator
Contributor
Author
|
Encoding nit addressed @bors r=oli-obk |
Collaborator
wesleywiser
approved these changes
Jan 19, 2023
Member
wesleywiser
left a comment
There was a problem hiding this comment.
Thanks for the quick turn around on this @compiler-errors!
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (4c83bd0): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 22, 2023
…mulacrum [beta] backport * Don't wf-check non-local RPITs rust-lang#107038 * Revert "Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard error" rust-lang#107133 * bump bootstrap 1.66.1 r? `@Mark-Simulacrum`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using
ty::is_impl_trait_defn(..).is_none()to check if we need to add WF obligations for an opaque type.This is supposed to be checking if the type is a TAIT, since RPITs' wfness is implied by wf checking its parent item, but since
is_impl_trait_defnreturnsNonefor non-local RPIT and async futures, we unnecessarily consider wf predicates for an RPIT if it is coming from a foreign crate.Fixes #107036
r? @oli-obk but feel free to reassign