Merged
Conversation
Collaborator
|
(rustbot has picked a reviewer for you, use r? to override) |
This comment was marked as resolved.
This comment was marked as resolved.
scottmcm
commented
Jan 18, 2023
| // (<https://graphics.stanford.edu/~seander/bithacks.html#CopyIntegerSign>) | ||
| // so delegate it to `Ord` which is already producing -1/0/+1 | ||
| // exactly like we need and can be the place to deal with the complexity. | ||
| self.cmp(&0) as _ |
Member
Author
There was a problem hiding this comment.
It's of course not a big deal, but self <=> 0 does feel nicer to me here than needing &0 and autoref.
(Just mentioning it, @joshtriplett, since I'd brought up spaceship in the meeting today. Obviously it's not a blocker for this PR.)
Member
Author
|
2-week reroll to hopefully get a less-busy reviewer: |
Member
|
@bors r+ |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 29, 2023
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#96763 (Fix maintainer validation message) - rust-lang#106540 (Insert whitespace to avoid ident concatenation in suggestion) - rust-lang#106763 (print why a test was ignored if its the only test specified) - rust-lang#106769 (libtest: Print why a test was ignored if it's the only test specified.) - rust-lang#106798 (Implement `signum` with `Ord`) - rust-lang#107006 (Output tree representation on thir-tree) - rust-lang#107078 (Update wording of invalid_doc_attributes docs.) - rust-lang#107169 (Pass `--locked` to the x test tidy call) - rust-lang#107431 (docs: remove colon from time header) - rust-lang#107432 (rustdoc: remove unused class `has-srclink`) - rust-lang#107448 (When stamp doesn't exist, should say Error, and print path to stamp file) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than needing to do things like #105840 for
signumtoo, might as well just implement that method usingOrd, since it's doing the same "I need-1/0/+1" behaviour thatcmpis already doing.This also seems to slightly improve the assembly: https://rust.godbolt.org/z/5oEEqbxK1