Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
r? jyn514 Looks like the alloc prelude was removed in 8007dfa, good catch.
I don't think this is accurate? 2021 has a page right here: https://doc.rust-lang.org/std/prelude/rust_2021/index.html |
|
Thanks for reviving my PRs!
What I meant was that that page is a pain to navigate and people are probably gonna use the But I can revert that change if you disagree with it |
|
I'd like to revert that change, yes, I think it's important for the v1 links to point to Happy to approve when that's done :) |
55fb752 to
60ab69d
Compare
|
Thanks! @bors r+ rollup |
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#105745 (docs(std): clarify remove_dir_all errors) - rust-lang#106456 (Correct `std::prelude` comment) - rust-lang#106599 (Change memory ordering in System wrapper example) - rust-lang#110838 (More `Typefoldable`/`TypeVisitable` cleanups) - rust-lang#110851 (compiletest: emit assembly-output header in error) - rust-lang#110853 (compiletest: add bpf-linker assembly support) - rust-lang#110878 (Add `known-bug` tests for 4 unsound issues) - rust-lang#110886 (`DepGraph` cleanups) - rust-lang#110905 (Remove invalid value from scraped-examples.md) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
(Read the changed file first for context.)
First,
allochas no prelude.Second, the docs for
v1don't matter since the prelude module already has all the doc links. Therust_2021module for instance also doesnt have a convenient doc page. However as I understand glob imports still cant be used because the items dont have the same stabilisation versions.