Merged
Conversation
Collaborator
|
r? @jyn514 (rustbot has picked a reviewer for you, use r? to override) |
Contributor
Author
|
I was thinking of adding tidy's unittests to |
Member
|
Yes, we definitely shouldn't run them as part of tidy -- I think we have a similar-ish split for Cargo (with cargotest vs. cargo itself). I think we should run them in CI though. |
Member
|
r=me unless you wanted to add the unittests to CI as part of this PR |
d100e5b to
59b80f5
Compare
Contributor
Author
|
Ok, I added it so that it gets checked in CI. @rustbot ready |
Member
|
Looks great, thanks! @bors r+ rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 31, 2022
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#106280 (docs: add link to `Path::join` in `PathBuf::push`) - rust-lang#106297 (rustdoc: merge scrape-help CSS) - rust-lang#106328 (Add comment explaining what the GUI scrape-examples-fonts test is about) - rust-lang#106334 (Fix tidy unittest.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tidy unittests weren't compiling due to a change made a long while ago to the
Versiontype.