Remove unused flex-grow CSS rule#105823
Remove unused flex-grow CSS rule#105823GuillaumeGomez wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
@bors r+ rollup |
|
@bors r- How is it not a flex item? These are direct children of example-wrap, which is display: flex right here. https://github.com/rust-lang/rust/blob/master/src/librustdoc/html/static/css/rustdoc.css#L530 |
|
It's this rule that is applied: https://github.com/rust-lang/rust/blob/master/src/librustdoc/html/static/css/rustdoc.css#L1979. So not flex items. |
|
How I discovered it:
|
|
Yeah, scraped examples are special. They use CSS grid for this while everything else uses flexbox. https://github.com/rust-lang/rust/blob/master/src/librustdoc/html/static/css/rustdoc.css#L1979 It would probably be a good idea to make a more elaborate PR to have example-wrap always use grid, |
|
I see. Closing in the meantime then. |
…es-code-blocks, r=notriddle rustdoc: Simplify CSS for scraped code examples code blocks It's another approach than rust-lang#105894 for rust-lang#105823. I simply removed the extra style added for the scraped code blocks which appears to be unneeded. r? `@notriddle`
It's not a flex item so the rule has no effect on it.
r? @notriddle