improve array_from_fn documenation#104839
Merged
bors merged 2 commits intorust-lang:masterfrom Nov 26, 2022
HintringerFabian:docs_array_from_fn
Merged
improve array_from_fn documenation#104839bors merged 2 commits intorust-lang:masterfrom HintringerFabian:docs_array_from_fn
bors merged 2 commits intorust-lang:masterfrom
HintringerFabian:docs_array_from_fn
Conversation
Collaborator
|
r? @scottmcm (rustbot has picked a reviewer for you, use r? to override) |
Collaborator
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
scottmcm
requested changes
Nov 25, 2022
library/core/src/array/mod.rs
Outdated
| /// // inferred to be 5, thus creating array of 5 elements. | ||
| /// let array = core::array::from_fn(|i| i); | ||
| /// | ||
| /// let array: [_; 5] = core::array::from_fn(|i| i); |
Member
There was a problem hiding this comment.
Given the big comment about type inference above this one, I think this example should stay of inferred width
Suggested change
| /// let array: [_; 5] = core::array::from_fn(|i| i); | |
| /// let array = core::array::from_fn(|i| i); |
library/core/src/array/mod.rs
Outdated
| /// // indexes are: 0 1 2 3 4 | ||
| /// assert_eq!(array, [0, 1, 2, 3, 4]); | ||
| /// | ||
| /// let array2: [_; 8] = core::array::from_fn(|i| i * 2); |
Member
There was a problem hiding this comment.
Then it would be good to mention the type annotation on this on to contrast with the first one.
library/core/src/array/mod.rs
Outdated
| /// // indexes are: 0 1 2 3 4 5 6 7 | ||
| /// assert_eq!(array2, [0, 2, 4, 6, 8, 10, 12, 14]); | ||
| /// | ||
| /// let bool_arr: [bool; 5] = core::array::from_fn(|i| i % 2 == 0); |
Member
There was a problem hiding this comment.
And for completeness, maybe show turbofishing for this one?
Suggested change
| /// let bool_arr: [bool; 5] = core::array::from_fn(|i| i % 2 == 0); | |
| /// let bool_arr = core::array::from_fn::<_, 5, _>(|i| i % 2 == 0); |
Contributor
Author
|
@rustbot ready |
scottmcm
approved these changes
Nov 26, 2022
Member
|
@bors r+ rollup=always |
Collaborator
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 26, 2022
…n, r=scottmcm improve array_from_fn documenation Improves array::from_fn documentation Fixes rust-lang#102609 There were also unresolved comments from [this PR rust-lang#100462](rust-lang#100462), which have been added to my PR
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 26, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#104121 (Refine `instruction_set` MIR inline rules) - rust-lang#104675 (Unsupported query error now specifies if its unsupported for local or external crate) - rust-lang#104839 (improve array_from_fn documenation) - rust-lang#104880 ([llvm-wrapper] adapt for LLVM API change) - rust-lang#104899 (rustdoc: remove no-op CSS `#help dt { display: block }`) - rust-lang#104906 (Remove AscribeUserTypeCx) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves array::from_fn documentation
Fixes #102609
There were also unresolved comments from this PR #100462, which have been added to my PR