minor changes to make method lookup diagnostic code easier to read#103937
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 4, 2022
Merged
minor changes to make method lookup diagnostic code easier to read#103937bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
@bors r+ |
Collaborator
| match self.tcx.hir().get_if_local(impl_def_id) { | ||
| // Unmet obligation comes from a `derive` macro, point at it once to | ||
| // avoid multiple span labels pointing at the same place. | ||
| Some(Node::Item(hir::Item { |
Contributor
There was a problem hiding this comment.
I'm pretty convinced that this code will never be triggered, but if it is, someone will report it as an ICE 😅
Contributor
There was a problem hiding this comment.
For this to be triggered, we need to have a nested obligation of a trait be reported as an unsatisfied predicate for a method to be applicable. We only construct nested trait obligations with ImplDerivedObligation causes for auto traits, which have no methods.
Member
There was a problem hiding this comment.
#105732 is here,
maybe we should add an delay_span_bug here for match with Some(node)?
@compiler-errors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 4, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#103367 (Remove std's transitive dependency on cfg-if 0.1) - rust-lang#103397 (Port `dead_code` lints to be translatable.) - rust-lang#103681 (libtest: run all tests in their own thread, if supported by the host) - rust-lang#103792 (Migrate `codegen_ssa` to diagnostics structs - [Part 2]) - rust-lang#103897 (asm: Work around LLVM bug on AArch64) - rust-lang#103937 (minor changes to make method lookup diagnostic code easier to read) - rust-lang#103958 (Test tidy should not count untracked paths towards entries limit) - rust-lang#103964 (Give a specific lint for unsafety not being inherited) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
chenyukang
reviewed
Dec 15, 2022
| @@ -248,7 +248,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { | |||
|
|
|||
| match error { | |||
| MethodError::NoMatch(NoMatchData { | |||
Member
There was a problem hiding this comment.
This block is tooo long, about 800 lines of code!
Is it worth to extract to a seperate sub-methods?
@compiler-errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The end result of around 4 days of trying to understand this 1000+ line long function- a bunch of tiny nitpicks
r? @compiler-errors