Fix capacity overflow issue during transmutability check#103831
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 5, 2022
Merged
Fix capacity overflow issue during transmutability check#103831bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @nagisa (rustbot has picked a reviewer for you, use r? to override) |
de49e26 to
749afe5
Compare
nagisa
reviewed
Nov 4, 2022
| @@ -0,0 +1,29 @@ | |||
| #![crate_type = "lib"] | |||
Member
There was a problem hiding this comment.
FWIW it is useful to name regression tests after the issues they come from. This has couple purposes:
- It is easy to see this is a regression test;
- Resolving to the original issue report takes a single dereference (rather than having to go through
git log, looking at the commit message and only then finding the issue number to load up.)
Not a huge deal either way though.
Member
|
@bors r+ thanks! |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (6b8d9dd): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…nagisa Fix capacity overflow issue during transmutability check Fixes rust-lang#103751
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103751