Merged
Conversation
- Make the structure of the two variants more similar. - Add some comments. - Move various conditional `use` items inside the function that uses them. - Inline some closures.
It took me a while to work this out.
Member
|
@bors r+
This hurts performance, right, because we have to start a thread even for very small programs? Does it make sense to avoid using a thread pool for the non-parallel compiler? We can use |
Collaborator
Contributor
Author
|
I haven't measured, but I'd be surprised (horrified) if the cost of spawning one thread is significant even on the smallest programs. |
Contributor
Author
|
@bors rollup=always |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 20, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#103221 (Fix `SelfVisitor::is_self_ty` ICE) - rust-lang#103230 (Clarify startup) - rust-lang#103281 (Adjust `transmute{,_copy}` to be clearer about which of `T` and `U` is input vs output) - rust-lang#103288 (Fixed docs typo in `library/std/src/time.rs`) - rust-lang#103296 (+/- shortcut now only expand/collapse, not both) - rust-lang#103297 (fix typo) - rust-lang#103313 (Don't label `src/test` tests as `A-testsuite`) - rust-lang#103315 (interpret: remove an incorrect assertion) - rust-lang#103319 (Improve "`~const` is not allowed here" message) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small follow-up to #102769.
r? @jyn514