resolve: Some cleanup, asserts and tests for lifetime ribs#102884
Merged
bors merged 3 commits intorust-lang:masterfrom Oct 15, 2022
Merged
resolve: Some cleanup, asserts and tests for lifetime ribs#102884bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
cjgillot
reviewed
Oct 11, 2022
Contributor
cjgillot
left a comment
There was a problem hiding this comment.
It took me some time to convince myself of the panics. Could you add a comment each time?
Contributor
Author
Well, the comment would be "I couldn't construct an example" in half of the cases. |
cjgillot
reviewed
Oct 11, 2022
Contributor
Author
|
Updated. |
Contributor
|
@bors r+ |
Collaborator
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Oct 15, 2022
resolve: Some cleanup, asserts and tests for lifetime ribs Follow up to rust-lang#98279 and friends. r? `@cjgillot`
This was referenced Oct 15, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 15, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#102773 (Use semaphores for thread parking on Apple platforms) - rust-lang#102884 (resolve: Some cleanup, asserts and tests for lifetime ribs) - rust-lang#102954 (Add missing checks for `doc(cfg_hide(...))`) - rust-lang#102998 (Drop temporaries created in a condition, even if it's a let chain) - rust-lang#103003 (Fix `suggest_floating_point_literal` ICE) - rust-lang#103041 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #98279 and friends.
r? @cjgillot