create def ids for impl traits during ast lowering#102483
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 1, 2022
Merged
create def ids for impl traits during ast lowering#102483bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
d275c25 to
f67909e
Compare
cjgillot
reviewed
Sep 29, 2022
f67909e to
ba9000c
Compare
This comment has been minimized.
This comment has been minimized.
ba9000c to
9080c2f
Compare
Member
Author
|
It turned out that this was way simpler to what I was trying to do. @cjgillot I think it's ready unless there's something outside ui tests that need to be blessed because def_ids ordering/numbers have changed now. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
This looks like a bug in the stable hasher. This branch is only used for item-relative spans ( |
9080c2f to
b2bef02
Compare
Member
Author
|
@cjgillot now should be ready |
Contributor
|
@bors r+ |
Collaborator
Member
Author
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 1, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#102361 (Fix ICE in const_trait check code) - rust-lang#102373 (Flush delayed bugs before codegen) - rust-lang#102483 (create def ids for impl traits during ast lowering) - rust-lang#102490 (Generate synthetic region from `impl` even in closure body within an associated fn) - rust-lang#102492 (Don't lower assoc bindings just to deny them) - rust-lang#102493 (Group together more size assertions.) - rust-lang#102521 (rustdoc: add missing margin to no-docblock methods) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @cjgillot