Skip to content

Added more const_closure functionality#102276

Merged
bors merged 3 commits intorust-lang:masterfrom
ink-feather-org:const_closure_ext
Sep 30, 2022
Merged

Added more const_closure functionality#102276
bors merged 3 commits intorust-lang:masterfrom
ink-feather-org:const_closure_ext

Conversation

@onestacked
Copy link
Contributor

@onestacked onestacked commented Sep 25, 2022

Enables ConstFnMutClosure to use a tuple of mutable references instead of just a mutable reference to a tuple.

Removes the new function, since it would barely be usable with this new code.

r? @fee1-dead

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 25, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 25, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 25, 2022
@onestacked onestacked force-pushed the const_closure_ext branch 2 times, most recently from 932c33b to d4e5e0b Compare September 25, 2022 18:40
@onestacked onestacked mentioned this pull request Sep 26, 2022
Merged
fee1-dead
fee1-dead reviewed Sep 26, 2022
View reviewed changes
fee1-dead
fee1-dead approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@fee1-dead fee1-dead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an internal change so I don't think this would interfere with new developments and discussions around the feature.

@fee1-dead
Copy link
Member

fee1-dead commented Sep 30, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 30, 2022

📌 Commit fa93a1a476d53dbd93c0eef12a330a60c1915f38 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2022
@fee1-dead
Copy link
Member

fee1-dead commented Sep 30, 2022

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 30, 2022
fee1-dead
fee1-dead reviewed Sep 30, 2022
View reviewed changes
library/core/src/const_closure.rs Outdated
Comment on lines 64 to 73
Copy link
Member

@fee1-dead fee1-dead Sep 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the nits, but this isn't formatted properly. The last brace should have no spaces before them, and all of these should have four spaces.

r=me once you are done

@fee1-dead
Copy link
Member

fee1-dead commented Sep 30, 2022

@bors delegate+

After you are done, mention bors and r=fee1-dead.

@bors
Copy link
Collaborator

bors commented Sep 30, 2022

✌️ @chriss0612 can now approve this pull request

@onestacked
Copy link
Contributor Author

onestacked commented Sep 30, 2022

@bors r=fee1-dead

@bors
Copy link
Collaborator

bors commented Sep 30, 2022

📌 Commit 10739d4 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 30, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 30, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 30, 2022
@bors
Auto merge of rust-lang#102520 - matthiaskrgr:rollup-7nreat0, r=matth…
877877a 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#102276 (Added more const_closure functionality)
 - rust-lang#102382 (Manually order `DefId` on 64-bit big-endian)
 - rust-lang#102421 (remove the unused :: between trait and type to give user correct diag…)
 - rust-lang#102495 (Reinstate `hir-stats.rs` test for stage 1.)
 - rust-lang#102505 (rustdoc: remove no-op CSS `h3.variant, .sub-variant h4 { border-bottom: none }`)
 - rust-lang#102506 (Specify `DynKind::Dyn`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3452d9d into rust-lang:master Sep 30, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 30, 2022
@onestacked onestacked deleted the const_closure_ext branch November 2, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fee1-dead fee1-dead fee1-dead approved these changes

Assignees

@fee1-dead fee1-dead

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.66.0

Development

Successfully merging this pull request may close these issues.

5 participants

@onestacked @rustbot @fee1-dead @bors @rust-highfive