Allow building rust-analyzer-proc-macro-srv as a standalone tool#101873
Merged
bors merged 2 commits intorust-lang:masterfrom Sep 17, 2022
Merged
Allow building rust-analyzer-proc-macro-srv as a standalone tool#101873bors merged 2 commits intorust-lang:masterfrom
rust-analyzer-proc-macro-srv as a standalone tool#101873bors merged 2 commits intorust-lang:masterfrom
Conversation
jyn514
approved these changes
Sep 16, 2022
Member
jyn514
left a comment
There was a problem hiding this comment.
Thanks! This makes sense to me. Can you also make a PR to the dev guide suggesting that people build this when they make a custom toolchain? It should go near the suggested workflow section, where we already have page about rustup.
This was referenced Sep 16, 2022
Member
Author
|
dev guide PR: rust-lang/rustc-dev-guide#1467 |
Member
|
@bors r+ Thanks! |
Collaborator
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 17, 2022
…v, r=jyn514
Allow building `rust-analyzer-proc-macro-srv` as a standalone tool
This PR allows building `rust-analyzer-proc-macro-srv` as a standalone tool via `x b proc-macro-srv-cli` (I thought that `x b rust-analyzer-proc-macro-srv` should work, but it doesn't for some reason...). Also this PR adds a copy of `rust-analyzer-proc-macro-srv` binary to `build/{triple}/{stage}/libexec/` when building `rust-analyzer-proc-macro-srv`, so that r-a can pick it up.
This is useful to make r-a (and I assume Intellij IDEA) to expand macros when using a custom, build from source toolchain.
r? `@jyn514`
[_zulip thread_](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/How.20to.20fix.20.60UnsupportedABI.60.20for.20custom.20toolchains.3F/near/299040175)
This was referenced Sep 17, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 17, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#101672 (array docs - advertise how to get array from slice) - rust-lang#101781 (Extend list of targets that support dyanmic linking for llvm tools) - rust-lang#101783 (Improve handing of env vars during bootstrap process) - rust-lang#101801 (add note for `layout_of` when query depth overflows) - rust-lang#101824 (rustdoc: add test cases for turning ``[Vec<T>]`` into ``[`Vec<T>`]``) - rust-lang#101861 (Update stdarch) - rust-lang#101873 (Allow building `rust-analyzer-proc-macro-srv` as a standalone tool) - rust-lang#101918 (rustdoc: clean up CSS for All Items and All Crates lists) - rust-lang#101934 (Continue migration of CSS themes) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows building
rust-analyzer-proc-macro-srvas a standalone tool viax b proc-macro-srv-cli(I thought thatx b rust-analyzer-proc-macro-srvshould work, but it doesn't for some reason...). Also this PR adds a copy ofrust-analyzer-proc-macro-srvbinary tobuild/{triple}/{stage}/libexec/when buildingrust-analyzer-proc-macro-srv, so that r-a can pick it up.This is useful to make r-a (and I assume Intellij IDEA) to expand macros when using a custom, build from source toolchain.
r? @jyn514
zulip thread