Migrate another part of rustc_infer to session diagnostic#101153
Merged
bors merged 8 commits intorust-lang:masterfrom Sep 8, 2022
Merged
Migrate another part of rustc_infer to session diagnostic#101153bors merged 8 commits intorust-lang:masterfrom
bors merged 8 commits intorust-lang:masterfrom
Conversation
Collaborator
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
davidtwco
requested changes
Aug 31, 2022
Member
davidtwco
left a comment
There was a problem hiding this comment.
Thanks for working on this, I've left an initial batch of comments.
compiler/rustc_infer/src/infer/error_reporting/nice_region_error/different_lifetimes.rs
Outdated
Show resolved
Hide resolved
Contributor
|
r? @davidtwco |
davidtwco
reviewed
Sep 6, 2022
Co-authored-by: David Wood <agile.lion3441@fuligin.ink>
…now supported by them
d7f24be to
ee74f92
Compare
Collaborator
|
Some changes occurred in need_type_info.rs cc @lcnr |
This comment has been minimized.
This comment has been minimized.
davidtwco
approved these changes
Sep 7, 2022
Member
|
Thanks! This is fantastic. @bors r+ |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 8, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#101153 (Migrate another part of rustc_infer to session diagnostic) - rust-lang#101399 (Shrink span for bindings with subpatterns.) - rust-lang#101422 (Hermit: Add File::set_time stub) - rust-lang#101455 (Avoid UB in the Windows filesystem code in... bootstrap?) - rust-lang#101498 (rustc: Parameterize `ty::Visibility` over used ID) - rust-lang#101549 (Use HashStable_Generic in rustc_type_ir) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably will migrate another file before marking this one as ready-to-merge.
@rustbot label +A-translation
r? rust-lang/diagnostics
cc #100717