Migrate part of rustc_infer to session diagnostic#100843
Merged
bors merged 7 commits intorust-lang:masterfrom Aug 29, 2022
Merged
Migrate part of rustc_infer to session diagnostic#100843bors merged 7 commits intorust-lang:masterfrom
bors merged 7 commits intorust-lang:masterfrom
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon. Please see the contribution instructions for more information. |
817803b to
d199838
Compare
Contributor
Author
Those are basically the same but the first one seems to fit better
51c18fa to
74f9973
Compare
davidtwco
requested changes
Aug 23, 2022
Member
davidtwco
left a comment
There was a problem hiding this comment.
This is a great start, thanks for working on it, I've left a couple comments.
Member
|
r? @davidtwco |
Collaborator
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki Some changes occurred in need_type_info.rs cc @lcnr |
davidtwco
approved these changes
Aug 24, 2022
Member
|
@bors r+ |
Collaborator
Contributor
|
@bors r+ |
Collaborator
|
💡 This pull request was already approved, no need to approve it again.
|
Collaborator
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 28, 2022
…piler-errors Migrate part of rustc_infer to session diagnostic
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 28, 2022
…piler-errors Migrate part of rustc_infer to session diagnostic
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 28, 2022
…piler-errors Migrate part of rustc_infer to session diagnostic
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 28, 2022
…piler-errors Migrate part of rustc_infer to session diagnostic
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 28, 2022
…piler-errors Migrate part of rustc_infer to session diagnostic
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 29, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#94890 (Support parsing IP addresses from a byte string) - rust-lang#96334 (socket `set_mark` addition.) - rust-lang#99027 (Replace `Body::basic_blocks()` with field access) - rust-lang#100437 (Improve const mismatch `FulfillmentError`) - rust-lang#100843 (Migrate part of rustc_infer to session diagnostic) - rust-lang#100897 (extra sanity check against consts pointing to mutable memory) - rust-lang#100959 (translations: rename warn_ to warning) - rust-lang#101111 (Use the declaration's SourceInfo for FnEntry retags, not the outermost) - rust-lang#101116 ([rustdoc] Remove Attrs type alias) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.