rustdoc: do not mark the contents of a skipped module as inlined#100207
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 8, 2022
Merged
rustdoc: do not mark the contents of a skipped module as inlined#100207bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @jsha (rust-highfive has picked a reviewer for you, use r? to override) |
Member
|
It would be great to get a quick review here, in case we decide to backport this into 1.63 beta (shipping as stable this upcoming Thursday). cc @rust-lang/rustdoc It would also be good for comments on whether it makes sense to backport this or instead drop #99738 from 1.63 -- see my comments on the issue #100204 (comment) |
Member
|
@bors r+ I think backporting this should be fine? Unsure. |
Collaborator
Member
|
@bors p=1 -- would like to get this landed and out on nightly quickly for any extra testing that'll give us |
Collaborator
|
⌛ Testing commit 2289955 with merge fb74b0bb979e91ea449358a8d04feded9baa4711... |
Collaborator
|
💥 Test timed out |
Member
|
@bors retry x64-msvc timed out |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (6a11cad): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 8, 2022
…Simulacrum [stable] 1.63.0 release Includes cherry picks of: * rust-lang#100207 * rust-lang/rust-clippy#9302 * Avoid ICE in rustdoc when using Fn bounds rust-lang#100205 r? `@Mark-Simulacrum`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 9, 2022
…mulacrum [beta] 1.64.0 branching Includes cherry picks of: * rust-lang#100207 * rust-lang/rust-clippy#9302 * rust-lang/rust@49b1904 (explicit_auto_deref into nursery) * Avoid ICE in rustdoc when using Fn bounds rust-lang#100205 r? `@Mark-Simulacrum`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100204