Document that RawWakerVTable functions must be thread-safe.#100128
Document that RawWakerVTable functions must be thread-safe.#100128bors merged 2 commits intorust-lang:masterfrom
RawWakerVTable functions must be thread-safe.#100128Conversation
Also add some intra-doc links and more high-level explanation of how `Waker` is used, while I'm here. Context: https://internals.rust-lang.org/t/thread-safety-of-rawwakervtables/17126
|
r? @scottmcm (rust-highfive has picked a reviewer for you, use r? to override) |
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
I don't know enough about tasks/futures to be a good reviewer here. r? libs |
|
r? @thomcc |
|
Hmm, can someone on @rust-lang/wg-async double-check this? |
thomcc
left a comment
There was a problem hiding this comment.
This looks fine to me. I kind of would like to have someone from wg-async sign off on it, just to make sure there isn't anything new this is stating subtly
|
After a reread through our APIs and docs I'm convinced this is fine and doesn't make any new guarantees. @bors r+ rollup |
…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#95005 (BTree: evaluate static type-related check at compile time) - rust-lang#99742 (Add comments about stdout locking) - rust-lang#100128 (Document that `RawWakerVTable` functions must be thread-safe.) - rust-lang#100956 (Reduce right-side DOM size) - rust-lang#101006 (Fix doc cfg on reexports) - rust-lang#101012 (rustdoc: remove unused CSS for `.variants_table`) - rust-lang#101023 (rustdoc: remove `type="text/css"` from stylesheet links) - rust-lang#101031 (Remove unused build dependency) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Thanks for the ping and for the PR, I agree it looks good! |
Also add some intra-doc links and more high-level explanation of how
Wakeris used, while I'm here.Context: https://internals.rust-lang.org/t/thread-safety-of-rawwakervtables/17126