Feature/loop break value#56
Merged
steveklabnik merged 4 commits intorust-lang:masterfrom May 26, 2017
Merged
Conversation
An inline code snippet was using triple quotes instead of single ones, breaking syntax highlight in vim.
This commit introduces to the reference the changes made by the loop_break_value feature, defined in RFC 1624.
Contributor
Author
|
Note: I had to use |
emilyalbini
reviewed
May 17, 2017
src/expressions.md
Outdated
| loop, but `continue 'label` may be used to specify the loop affected. | ||
| A `continue` expression is only permitted in the body of a loop. | ||
|
|
||
| ### Break-with-value |
Member
There was a problem hiding this comment.
This can be worded a bit better. Something like "break with return values" maybe?
4 tasks
Havvy
added a commit
to Havvy/reference
that referenced
this pull request
May 17, 2017
I went with "associated break" here to match the terminology given by PR rust-lang#56.
steveklabnik
approved these changes
May 17, 2017
Contributor
steveklabnik
left a comment
There was a problem hiding this comment.
This looks good to me! We should wait until the tests actually pass due to the feature landing, though 👍
Contributor
|
I think this just needs the tests to be rerun (by pushing something) to be merged? |
Contributor
|
@matthewjasper yup and it now passes. Woo! Thanks @dhardy ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue from @pietroalbini's PR #53.
Tracking issue: #37339.
This makes quite a few changes to the structure and content of the whole loops section, hopefully for the better.
Really this whole document needs an index, but that's another job.