Merged
Conversation
RalfJung
commented
May 17, 2021
| // a release sequence. | ||
| let pointer = &*ptr.0; | ||
| pointer.store(Box::into_raw(Box::new(MaybeUninit::uninit())), Ordering::Relaxed); | ||
| pointer.store(Box::into_raw(Box::new_uninit()), Ordering::Relaxed); |
Member
Author
There was a problem hiding this comment.
@JCTyblaidd I had to change this test as (I think) a bug got fixed where the "write" of a MaybeUninit::uninit() into this box did not trigger the "write" hook.
bors
added a commit
that referenced
this pull request
May 17, 2021
stop relying on c_str/wide_str helpers in rustc This is a part of #1804 that we can already do.
This comment has been minimized.
This comment has been minimized.
dc3b8fe to
e4462d5
Compare
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2021
CTFE core engine allocation & memory API improvemenets This is a first step towards rust-lang/miri#841. - make `Allocation` API offset-based (no more making up `Pointer`s just to access an `Allocation`) - make `Memory` API higher-level (combine checking for access and getting access into one operation) The Miri-side PR is at rust-lang/miri#1804. r? `@oli-obk`
Member
Author
|
@bors r+ |
Contributor
|
📌 Commit d1e5eee has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
May 19, 2021
update for Memory API changes The Miri side of rust-lang/rust#85376.
Member
Author
|
@bors retry r+ |
Contributor
|
📌 Commit e4a2715 has been approved by |
bors
added a commit
that referenced
this pull request
May 19, 2021
update for Memory API changes The Miri side of rust-lang/rust#85376.
Contributor
Contributor
|
💔 Test failed - checks-actions |
Member
Author
|
Oh interesting, tests are failing only for |
Member
Author
|
@bors r+ |
Contributor
|
📌 Commit aba96b8 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
christian-schilling
pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
CTFE core engine allocation & memory API improvemenets This is a first step towards rust-lang/miri#841. - make `Allocation` API offset-based (no more making up `Pointer`s just to access an `Allocation`) - make `Memory` API higher-level (combine checking for access and getting access into one operation) The Miri-side PR is at rust-lang/miri#1804. r? `@oli-obk`
christian-schilling
pushed a commit
to christian-schilling/rustc_codegen_cranelift
that referenced
this pull request
Jan 27, 2026
CTFE core engine allocation & memory API improvemenets This is a first step towards rust-lang/miri#841. - make `Allocation` API offset-based (no more making up `Pointer`s just to access an `Allocation`) - make `Memory` API higher-level (combine checking for access and getting access into one operation) The Miri-side PR is at rust-lang/miri#1804. r? `@oli-obk`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Miri side of rust-lang/rust#85376.