Use NOCANCEL variants for close on Mac #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm seeing failures on Mac like |
Member
|
Heh that's to be expected! It's ok to just add an exception for that as we're conciously expecting it to be different than the default |
The default on OS X does not provide clear errors, instead the NOCANCEL variants should be used. These are available as of OS X 10.6 onwards.
Contributor
Author
|
@Susurrus I think you mean @DanielJoyce. :) |
Contributor
Author
|
@docbrown Sorry, you're right! Too many PRs going around! |
Member
|
@bors: r+ |
Contributor
|
📌 Commit 9b9f36a has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
May 19, 2017
Use NOCANCEL variants for close on Mac The default `close()` on OS X does not provide clear errors, instead the `$NOCANCEL` variants should be used. These are available as of OS X 10.6 onwards. Fixes #595.
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
close()on OS X does not provide clear errors, instead the$NOCANCELvariants should be used. These are available as of OS X 10.6 onwards.Fixes #595.