Skip to content

Lift IFA_ -constants from linux/gnu to linux#4185

Merged
tgross35 merged 1 commit intorust-lang:mainfrom
jtt:add-missing-ifa-flags
Dec 9, 2024
Merged

Lift IFA_ -constants from linux/gnu to linux#4185
tgross35 merged 1 commit intorust-lang:mainfrom
jtt:add-missing-ifa-flags

Conversation

@jtt
Copy link
Contributor

@jtt jtt commented Dec 8, 2024 •
edited
Loading

Description

Lift IFA_ -constants from linux/gnu to linux/mod.rs

Sources

Constants are defined in linux/if_addr.h

Checklist

  • [x ] Relevant tests in libc-test/semver have been updated
  • [ x] No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • [x ] Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Dec 8, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@tgross35
Copy link
Contributor

tgross35 commented Dec 8, 2024

Since these are uapi, could you just lift the existing gnu definitions to Linux/mod.rs?

@jtt jtt force-pushed the add-missing-ifa-flags branch from a7e1fd0 to 315a6dc Compare December 8, 2024 21:40
@jtt jtt force-pushed the add-missing-ifa-flags branch from 315a6dc to 70c1e82 Compare December 8, 2024 22:06
@rustbot rustbot added the O-gnu label Dec 8, 2024
@jtt jtt changed the title Add missing IFA_ constants to linux/musl Lift IFA_ -constants from linux/gnu to linux Dec 8, 2024
@jtt
Copy link
Contributor Author

jtt commented Dec 8, 2024

Lifted to constants to linux/mod.rs and updated the wording of this PR to reflect that. I would also like to nominate this change to be included in stable branch. @rustbot label stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Dec 8, 2024
tgross35
tgross35 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tgross35 tgross35 added this pull request to the merge queue Dec 9, 2024
Merged via the queue into rust-lang:main with commit 69362ce Dec 9, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Dec 9, 2024
@jtt @tgross35
Lift IFA_* constants from linux/gnu to linux
8592ff9 
(backport <rust-lang#4185>)
(cherry picked from commit 70c1e82)
@tgross35 tgross35 mentioned this pull request Dec 9, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Dec 9, 2024
@shadow3aaa shadow3aaa mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@JohnTitor JohnTitor

Labels

O-gnu O-linux O-musl O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jtt @rustbot @tgross35 @JohnTitor