Skip to content

Add gnu_get_[version|release] for glibc#2862

Merged
bors merged 2 commits into
rust-lang:masterfrom
LegNeato:master
Aug 11, 2022
Merged

Add gnu_get_[version|release] for glibc#2862
bors merged 2 commits into
rust-lang:masterfrom
LegNeato:master

Conversation

@LegNeato

@LegNeato LegNeato commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

@rust-highfive

Copy link
Copy Markdown

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu

Amanieu commented Aug 4, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

📌 Commit f415078 has been approved by Amanieu

It is now in the queue for this repository.

@bors

bors commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

⌛ Testing commit f415078 with merge f1d38be...

@bors

bors commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-actions

@LegNeato

LegNeato commented Aug 8, 2022

Copy link
Copy Markdown
Contributor Author

I don't think this failure was caused by my code, any action on me?

Comment thread libc-test/build.rs Outdated
@LegNeato

LegNeato commented Aug 10, 2022

Copy link
Copy Markdown
Contributor Author

When I had the include path wrong it failed in CI. Once I had the correct include path it succeeded. So something in CI was able to pick it up.

The functions were introduced in version 2.1, which was released in 1999:

https://sourceware.org/git/?p=glibc.git;a=blob;f=csu/Versions;h=8e1b21948e8d7568c3e61caeaeb719cdaf110272;hb=HEAD#l6

I don't see anything to suggest it is optional / can be turned off, though the GNU manual notes:

This function is missing on some platforms: macOS 11.1, FreeBSD 13.0, NetBSD 9.0, OpenBSD 6.7, Minix 3.1.8, AIX 5.1, HP-UX 11, IRIX 6.5, Solaris 11.4, Cygwin 2.9, mingw, MSVC 14, Android 9.0.

It looks like alpine linux uses uclibc, which does not include the header. Does homu use alpine linux as its docker image base? If so that could account for the discrepancy...CI uses an image with glibc so the header was found and passed, homu uses alpine so it can't find the header and the merge fails?

@Amanieu

Amanieu commented Aug 11, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

📌 Commit f49efe4 has been approved by Amanieu

It is now in the queue for this repository.

@bors

bors commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

⌛ Testing commit f49efe4 with merge aa0f5b5...

@bors

bors commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-actions

@Amanieu

Amanieu commented Aug 11, 2022

Copy link
Copy Markdown
Member

@bors retry

@bors

bors commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

⌛ Testing commit f49efe4 with merge f742325...

@bors

bors commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: Amanieu
Pushing f742325 to master...

@bors bors merged commit f742325 into rust-lang:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants