apple: Add openpty(3) and forkpty(3)#202
Conversation
cc7e25c to
750c1bb
Compare
|
Thanks! Right now the scope of this library doesn't include |
|
Ah I misunderstood your reply to #195 maybe! Linux man page says They're available on Linux and all the bsdlikes; missing on Solaris. On non-OS X, they require linking with |
|
Ok, in that case I think it'd be fine to add these to Linux bindings, but we should leave them out elsewhere for now as they require an extra library to get linked. |
|
It's OS X that doesn't require linking anything else. For the other platforms, I think libutil is always available, but I'm fine with removing them for now, which I've done.
Would the amendment proposal itself need to be an RFC? |
|
Oh sorry, but yeah it's fine to add OSX for now if it doesn't require more libs. Also looks like the failure here was spurious, so I'll restart the build.
Not necessarily a full fledged RFC itself, but a PR to the RFCs repo for sure. |
|
I guess I need to figure out the implications of |
|
The |
|
That's what I thought. I'll survey a few major Linux distros if / when I move to open a PR on the RFC. Thanks for clarifying! |
|
I opened a PR on the RFC: rust-lang/rfcs#1529 |
|
@alexcrichton could this be merged as is, or should we wait for resolution of the RFC and add it to all platforms at once? |
|
Let's hold off on this for now until the RFC reaches a conclusion |
|
👍 |
|
Oh wait sorry I just realized this is only adding for OSX, oh yeah this is fine to merge once CI is green. |
apple: Add openpty(3) and forkpty(3)
|
Oh yeah, should have pointed that out. :-) |
The functions were added for Apple in rust-lang#202. Adding them to other platforms was pending an amendment to RFC 1291 to expand the scope of libc to include libutil. The amendment was merged as rust-lang/rfcs#1529
The functions were added for Apple in rust-lang#202. Adding them to other platforms was pending an amendment to RFC 1291 to expand the scope of libc to include libutil. The amendment was merged as rust-lang/rfcs#1529
unix: Add openpty(3) and forkpty(3) for non-Apple platforms The functions were added for Apple in #202. Adding them to other platforms was pending an amendment to RFC 1291 to expand the scope of libc to include libutil. The amendment was merged as rust-lang/rfcs#1529
The functions were added for Apple in rust-lang#202. Adding them to other platforms was pending an amendment to RFC 1291 to expand the scope of libc to include libutil. The amendment was merged as rust-lang/rfcs#1529
unix: Add openpty(3) and forkpty(3) for non-Apple platforms The functions were added for Apple in #202. Adding them to other platforms was pending an amendment to RFC 1291 to expand the scope of libc to include libutil. The amendment was merged as rust-lang/rfcs#1529
* Add _mm_[mask_]gatheri32_epi32
* Add _mm[256][_mask]_i32gather_{epi64, pd}
* Add _mm[256][_mask]_gather_ps
* Add _mm[256][_mask]_i64gather_{epi32, epi64, ps, pd}
No description provided.