Skip to content

Check style using rustfmt and reformat#1246

Merged
bors merged 1 commit intorust-lang:masterfrom
gnzlbg:rustfmt_style
Feb 7, 2019
Merged

Check style using rustfmt and reformat#1246
bors merged 1 commit intorust-lang:masterfrom
gnzlbg:rustfmt_style

Conversation

@gnzlbg
Copy link
Copy Markdown
Contributor

@gnzlbg gnzlbg commented Feb 7, 2019

A couple of recent PRs attempt to reformat the library using rustfmt and run into issues against libc's style checker because rustfmt default settings differ.

This PR uses the rustfmt-preview from nightly to check that the library is appropriately formatted, adding a style as similar to libc's style as possible, so that both style checkers work properly simultaneously.

@rust-highfive
Copy link
Copy Markdown

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@gnzlbg
Copy link
Copy Markdown
Contributor Author

gnzlbg commented Feb 7, 2019

@bors: r+

@bors
Copy link
Copy Markdown
Contributor

bors commented Feb 7, 2019

📌 Commit 0a5484e has been approved by gnzlbg

@bors
Copy link
Copy Markdown
Contributor

bors commented Feb 7, 2019

⌛ Testing commit 0a5484e with merge f181a62...

bors added a commit that referenced this pull request Feb 7, 2019
Check style using rustfmt and reformat

A couple of recent PRs attempt to reformat the library using rustfmt and run into issues against libc's style checker because rustfmt default settings differ.

This PR uses the rustfmt-preview from nightly to check that the library is appropriately formatted, adding a style as similar to libc's style as possible, so that both style checkers work properly simultaneously.
@gnzlbg
Copy link
Copy Markdown
Contributor Author

gnzlbg commented Feb 7, 2019

@bors: retry

@bors
Copy link
Copy Markdown
Contributor

bors commented Feb 7, 2019

⌛ Testing commit 0a5484e with merge 217cbfa...

bors added a commit that referenced this pull request Feb 7, 2019
Check style using rustfmt and reformat

A couple of recent PRs attempt to reformat the library using rustfmt and run into issues against libc's style checker because rustfmt default settings differ.

This PR uses the rustfmt-preview from nightly to check that the library is appropriately formatted, adding a style as similar to libc's style as possible, so that both style checkers work properly simultaneously.
@bors
Copy link
Copy Markdown
Contributor

bors commented Feb 7, 2019

💔 Test failed - checks-cirrus

@gnzlbg
Copy link
Copy Markdown
Contributor Author

gnzlbg commented Feb 7, 2019

@bors: retry

@bors
Copy link
Copy Markdown
Contributor

bors commented Feb 7, 2019

⌛ Testing commit 0a5484e with merge a2bf9f1...

bors added a commit that referenced this pull request Feb 7, 2019
Check style using rustfmt and reformat

A couple of recent PRs attempt to reformat the library using rustfmt and run into issues against libc's style checker because rustfmt default settings differ.

This PR uses the rustfmt-preview from nightly to check that the library is appropriately formatted, adding a style as similar to libc's style as possible, so that both style checkers work properly simultaneously.
@bors
Copy link
Copy Markdown
Contributor

bors commented Feb 7, 2019

☀️ Test successful - checks-cirrus, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing a2bf9f1 to master...

@bors bors merged commit 0a5484e into rust-lang:master Feb 7, 2019
@bors bors mentioned this pull request Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants