Switch serde test to fnv to avoid 32bit issues#214
Merged
bors merged 2 commits intorust-lang:masterfrom Dec 9, 2020
Merged
Conversation
Member
|
@bors r+ |
Contributor
|
📌 Commit 6649ebc has been approved by |
bors
added a commit
that referenced
this pull request
Nov 29, 2020
Switch serde test to fnv to avoid 32bit issues Currently the serde test depends on the order of the items in the hashmap. FxHash uses different multiplication constants on 32bit and 64bit architectures making the test fail if run on 32bit systems. This switches to fnv which is fully deterministic.
Contributor
Contributor
|
💔 Test failed - checks-travis |
Contributor
Author
|
@bors try |
Contributor
|
@tkaitchuck: 🔑 Insufficient privileges: not in try users |
Member
|
@bors r+ |
Contributor
|
📌 Commit cb6f817 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the serde test depends on the order of the items in the hashmap. FxHash uses different multiplication constants on 32bit and 64bit architectures making the test fail if run on 32bit systems.
This switches to fnv which is fully deterministic.