Conversation
Signed-off-by: Matthew Gleich <git@mattglei.ch>
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @carols10cents (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
LGTM, thanks! 👍 @bors r+ |
|
📌 Commit 1ef88c8 has been approved by |
|
☀️ Test successful - checks-actions |
🍱 Crop favicon Hello! At first glance I found doc.rust-lang.org/cargo's favicon to be a bit small compared to other site's favicons. Looked into it and found that the logo hasn't been cropped. All I did was crop the favicon in this PR. As you can see from the image below (new favicon on the right) it looks much better:  This has been done to crates.io's favicon as well in rust-lang/crates.io#3411. Thanks, you maintainers! :)
Hello! At first glance I found crates.io's favicon to be a bit small compared to other site's favicons. Looked into it and found that the logo hasn't been cropped. All I did was crop the favicon in this PR. As you can see from the image below (new favicon on the right) it looks much better:
Thank you, maintainers! :)