Disable f16 for LoongArch64#722
Merged
tgross35 merged 2 commits intorust-lang:masterfrom Nov 1, 2024
heiher:loong64-no-f16
Merged
Disable f16 for LoongArch64#722tgross35 merged 2 commits intorust-lang:masterfrom heiher:loong64-no-f16
f16 for LoongArch64#722tgross35 merged 2 commits intorust-lang:masterfrom
heiher:loong64-no-f16
Conversation
Disable `f161` for LoongArch64 due to incorrect code generation on LLVM 19, which causes failures in `testcrate/tests/conv.rs`. This workaround will remain in place until llvm/llvm-project#109093 is merged or we upgrade to LLVM 20.
Contributor
|
Do tests pass if you only disable FFI calls here compiler-builtins/testcrate/build.rs Lines 55 to 66 in d4a3955 |
Contributor
Author
No, they are still failing. |
tgross35
reviewed
Nov 1, 2024
tgross35
approved these changes
Nov 1, 2024
Contributor
tgross35
left a comment
There was a problem hiding this comment.
Thanks for checking, I updated the comment but this lgtm
Merged
Contributor
|
If you need it in rust-lang/rust, this is released in 0.1.138 https://github.com/rust-lang/compiler-builtins/releases/tag/compiler_builtins-v0.1.138. Will probably be a few days before we can bump to that version since a few builtins updates are already queued. |
tgross35
pushed a commit
that referenced
this pull request
Jan 31, 2026
Disable `f161` for LoongArch64 due to incorrect code generation on LLVM 19, which causes failures in `testcrate/tests/conv.rs`. This workaround will remain in place until llvm/llvm-project#109093 is merged or we upgrade to LLVM 20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable
f161for LoongArch64 due to incorrect code generation on LLVM 19, which causes failures intestcrate/tests/conv.rs. This workaround will remain in place until llvm/llvm-project#109093 is merged or we upgrade to LLVM 20.