Skip to content

Fixes #8783 #8910

Closed
aniljava wants to merge 1 commit intorust-lang:masterfrom
aniljava:master
Closed

Fixes #8783 #8910
aniljava wants to merge 1 commit intorust-lang:masterfrom
aniljava:master

Conversation

@aniljava
Copy link
Contributor

@aniljava aniljava commented Nov 28, 2020

  • discover_author called before init_vcs
  • if $USER is not defined or be obtained, defaults to empty author list

@aniljava
Fixes #8783
d22ee90 
 - discover_author called before init_vcs
 - if $USER is not defined or be obtained, defaults to empty author list
@rust-highfive
Copy link

rust-highfive commented Nov 28, 2020

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 28, 2020
@aniljava
Copy link
Contributor Author

aniljava commented Nov 29, 2020

First timer here !. Closing for the failed test, will create new pull request with test and rustfmt.

@aniljava aniljava closed this Nov 29, 2020
@Eh2406
Copy link
Contributor

Eh2406 commented Nov 29, 2020 via email

@aniljava aniljava mentioned this pull request Nov 29, 2020
Merged
bors added a commit that referenced this pull request Dec 3, 2020
@bors
Auto merge of #8912 - aniljava:master, r=alexcrichton
78beb37 
Fixes #8783 , cargo new fails without a author name or email

If user can not be obtained from git or env variables $USER, new command defaults to empty author in generated Cargo.toml

Could not edit old PR(#8910 8783) as the original clone was deleted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ehuss ehuss

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aniljava @rust-highfive @Eh2406 @ehuss