Merged
Conversation
|
r? @ehuss (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
I saw #7725. At least, these added tests seem to be correct at the moment. So I added tests first. |
cd64812 to
85d4cad
Compare
ehuss
reviewed
Dec 28, 2019
tests/testsuite/pkgid.rs
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| p.cargo("build").run(); | |
| p.cargo("generate-lockfile").run(); |
I think this would make the purpose clearer (pkgid just needs a lock file), and would make the test faster (our tests tend to be a little too heavy).
Contributor
Author
There was a problem hiding this comment.
I fixed it. Thanks for your review!
85d4cad to
a28d9a1
Compare
Contributor
|
Thanks! @bors r+ |
Contributor
|
📌 Commit a28d9a1 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Dec 29, 2019
Add test for `cargo pkgid` There was no test for `cargo pkgid` command.
Contributor
|
☀️ Test successful - checks-azure |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jan 7, 2020
Update cargo 9 commits in 86134e7666a088682f20b76278c3ee096a315218..6e1ca924a67dd1ac89c33f294ef26b5c43b89168 2019-12-23 16:08:07 +0000 to 2020-01-06 19:11:37 +0000 - Fix dynamic linking for Windows UWP MSVC targets (rust-lang/cargo#7758) - Fix CARGO_TARGET_triple_LINKER environment variable. (rust-lang/cargo#7763) - Remove metadata dep_kinds duplicates. (rust-lang/cargo#7756) - Check for a source defined multiple times. (rust-lang/cargo#7751) - Fix typo. (rust-lang/cargo#7735) - Fix config env vars that are prefix of another with underscore. (rust-lang/cargo#7748) - Add test for `cargo pkgid` (rust-lang/cargo#7741) - Add a note to the error message for using --feature / --no-default-features in a virtual workspace (rust-lang/cargo#7742) - Fix debug message. (rust-lang/cargo#7749)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no test for
cargo pkgidcommand.