Only apply default-members when building root manifest#6755
Only apply default-members when building root manifest#6755Nemo157 wants to merge 2 commits intorust-lang:masterfrom
Conversation
|
r? @ehuss (rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks for updating the documentation. ❤️ I'm slightly positive to this change. I want to see what others at @rust-lang/cargo think about it. The summary is: This changes Without default-members, nothing changes:
With default members, this PR changes the last two lines in this table from
I'm a little concerned this may disrupt existing workflows. It may be a little more consistent with the non-default-members case. I'm also curious what @SimonSapin thinks. He added it for servo, though it appears servo no longer uses it. I don't use any projects with this feature, so I don't have any experience with it. |
|
This seems like a reasonable change in behavior to me as well! |
66cb21d to
2eeed70
Compare
|
I've rebased your doc suggestions in. |
Fix spurious error in dirty_both_lib_and_test. On HFS, if it runs fast enough, the mtimes will be equal, causing it to fail to rebuild. Seen on #6755 https://travis-ci.com/rust-lang/cargo/jobs/185412514
|
☔ The latest upstream changes (presumably #6791) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I'm gonna close this since it's been inactive for some time now, but it can of course be resubmitted! (just trying to help clear out the queue) |
|
@Nemo157 any plans to pick this back up? I've run into the same unexpected behaviour when using |
|
I've rebased the branch, and the tests still pass. I was waiting on the feedback that @ehuss requested above, if they think that consensus on merging this can be had I'll happily open another PR for it. I'm not working on the project where I was having this issue much anymore so I didn't have the motivation to try and push for getting this merged. |
|
@ehuss do you have any input on moving forward with this PR? I'd like to use the |
|
I have posted a request for feedback at https://internals.rust-lang.org/t/cargo-change-in-workspace-default-members/10649. If there aren't any significant objections, then I'll go ahead and approve this PR. |
|
I haven't seen any objections, so I'm going to go ahead and merge this. However, github won't let me reopen, so I will open a new PR and merge that (#7270). |
Fixes #5932
The first commit includes all actual changes, the second commit is just running Asciidoctor on the already updated man-pages source, so I suggest looking at the individual commits.